Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing standardization #31

Closed
josherrickson opened this issue Mar 14, 2022 · 1 comment
Closed

testing standardization #31

josherrickson opened this issue Mar 14, 2022 · 1 comment
Assignees

Comments

@josherrickson
Copy link
Owner

josherrickson commented Mar 14, 2022

For testing, I'd like to see the following standardized such that each exported function has the following tests.

  1. Ensure runner functions run without error and return the "expected objects".
  2. Ensure exported functions run without error and return the "expected objects".
  3. Ensure exported functions with algorithm=default runs without error, and returns the same if passed no argument.
  4. Ensure exported functions work with all valid algorithms.
  5. Ensure exported functions fail if passed an invalid algorithm.

Currently 1 & 2 seem fairly well tested, 3 is not tested (see #29 for an example of where tests should have helped us), 4 & 5 are mostly tested. Let's try and get these all to "are completely tested" status.

Note: Expected object focused on a) type (e.g. vector, list?) and b) size. We should move away from testing the explicit values.

Edit: 2. and 4. should be tested with both default arguments (if given) and specific values.

@josherrickson josherrickson self-assigned this Mar 14, 2022
josherrickson added a commit that referenced this issue Mar 15, 2022
@josherrickson
Copy link
Owner Author

See above commit for a template.

josherrickson added a commit that referenced this issue Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant