Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use npm install #12

Merged
merged 1 commit into from
Nov 23, 2018
Merged

ci: use npm install #12

merged 1 commit into from
Nov 23, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Nov 23, 2018

We should use npm install to get the same results that the consumers of this library get as lockfiles are not used by npmjs.

Checks

  • I've checked there are no linting errors.
  • I've checked the code is still at 100% test coverage.

Added Actions (if relevant)

  • List added actions here...

Are you happy to be listed as a contributor in the actions list here?

Yes

Any other information / comments

If this is your first time contributing, I'd love to hear what you thought about the process. Was it easy/hard to find the information you were looking for? Did the Contributing Guide make sense? What were your stumbling blocks? Basically, any and all feedback is encouraged!

@joshfarrant joshfarrant merged commit 12b49fe into joshfarrant:master Nov 23, 2018
@joshfarrant
Copy link
Owner

Good idea, thanks again!

@DanielRuf DanielRuf deleted the ci/use-npm-install branch November 23, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants