Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getFile action #607

Closed
wants to merge 2 commits into from
Closed

Added getFile action #607

wants to merge 2 commits into from

Conversation

jtwebb
Copy link

@jtwebb jtwebb commented Feb 24, 2021

Checks

  • I've checked there are no linting errors.
  • I've checked the code is still at 100% test coverage.

Added Actions (if relevant)

  • getFile

Are you happy to be listed as a contributor on Shortcuts.fun?

Yes

Any other information / comments

The process wasn't too bad. I'd say the biggest hiccup was that plist isn't supported when parsing. (#542) is what saved me and should probably be merged in. The other thing that took me a second to realize is that if the action options are default then they won't show up when parsed. You have to toggle everything to a non-default state to see all the options.

But other than those two things, everything went rather smooth. I really like this framework. It's extremely easy to use.

@jtwebb jtwebb mentioned this pull request Feb 24, 2021
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jtwebb jtwebb closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant