Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

Woodman crashes on empty messages sent to the console #32

Open
tidoust opened this issue Jan 28, 2014 · 0 comments
Open

Woodman crashes on empty messages sent to the console #32

tidoust opened this issue Jan 28, 2014 · 0 comments
Assignees
Labels

Comments

@tidoust
Copy link
Contributor

tidoust commented Jan 28, 2014

Woodman does not like it when the final message it is about to send to the console is empty. This happens when:

  1. the pattern makes it possible to generate an empty message as in woodman.load('console %message');
  2. the call to the logging function does not provide any useful message as in logger.log(), logger.log(null) or logger.log('{}')

This should hardly ever occur in practice since it does not make a lot of sense to log nothing.

@ghost ghost assigned tidoust Jan 28, 2014
tidoust pushed a commit that referenced this issue Jan 28, 2014
The code was incorrectly expecting that the resulting message to
send to the console was always set. It may not be if the caller
does not provide any parameter as in `logger.log()`
tidoust pushed a commit that referenced this issue Jan 28, 2014
- Bug fix: Console appender crashed when given null messages (#32)
- New RegexLoggerNameFilter filter (#30)
tidoust pushed a commit that referenced this issue Jan 29, 2014
Same bug as in #32: the console appender also expected the final
bit to send to the console to be a string and not to be an object.
However, in browser environments, Woodman typically send objects
as-is to the console.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant