Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-word nicknames and normalized professional suffixes #8

Merged
merged 1 commit into from
Mar 9, 2015
Merged

multi-word nicknames and normalized professional suffixes #8

merged 1 commit into from
Mar 9, 2015

Conversation

gh-o-st
Copy link
Contributor

@gh-o-st gh-o-st commented Mar 8, 2015

  • professional suffix now gets normalized if it's found in the dictionary
  • nickname parsing now allows for multi-word nicknames
  • removed single quote nickname markers to prevent clashes with names containing apostrophes (primarily Arabic transliterations)
  • added an additional compound identifier (der)
  • some people write their suffix in numeric form, dictionary now allows for this

@gh-o-st
* broke parsing of professional suffix out into its own method
8a7c09c 
* professional suffix now gets normalized if it's found in the dictionary

* nickname parsing now allows for multi-word nicknames

* removed single quote nickname markers to prevent clashes with names containing apostrophes (primarily Arabic transliterations)

* added an additional compound identifier (der)

* some people write their suffix in numeric form, dictionary now allows for this
joshfraser added a commit that referenced this pull request Mar 9, 2015
@joshfraser
Merge pull request #8 from UberNerdBoy/master
e34673d 
multi-word nicknames and normalized professional suffixes
@joshfraser joshfraser merged commit e34673d into joshfraser:master Mar 9, 2015
@joshfraser
Copy link
Owner

Awesome. Thanks for doing this.

I'd love to hear your thoughts on changing nickname to be a first class citizen that is always returned.

@gh-o-st
Copy link
Contributor Author

gh-o-st commented Mar 9, 2015

You mean removing the option to simply discard the nickname if it exists? I don't think there's a problem with that... I mean, since the output of the function is an associative array anyway, the user can choose to use or discard any of the pieces of information...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gh-o-st @joshfraser