-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permalink never set (or used) #29
Comments
@joshfrench Just pinging you on this. Is the app still maintained? Should I do a pull request fixing this? |
Sorry for the delay! Akismet does collect that parameter, and omitting from Rakismet was an oversight. I'd love a pull request if you feel like implementing it. Thanks for catching that! |
Yeah it seems as simple as adding it to a few arrays of yours. I'll gladly submit a PR. I've been having MASSIVE spam issues on my sites and want to see any additional data points I can give akismet. Are there any other parameters they take? Where did you find the specs when creating this? All I can find is parsing through library code, where I saw they take the PHP _SERVER array. Curious if they would take some kind of RoR equivalent or any other data points we're missing.. |
The official API docs are here: http://akismet.com/development/api/ It's not clear if they recommend sending $_SERVER in addition to the listed params, or if they're just suggesting you use that array to populate the data you send back to them. None of their code samples send $_SERVER whole, so I'd always assumed it was the latter. They've been pretty helpful in the past though, it would be a good question for them. |
@joshfrench Looks like they will accept any HTTP header as a parameter to help them parse. Exact wording from them:
|
@joshfrench I've submitted two PRs to you. One with the permalink fix. The other will send HTTP_ headers (all they care about from $_SERVER -- if middleware is enabled). All of this is from communication with them. Let me know if you can merge next week and I can work with Akismet to make sure they're using these data points from us. |
Closed via 17c9e1c |
I noticed the readme makes reference to sending the permalink:
But then it's never used in the actual code.
The text was updated successfully, but these errors were encountered: