Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Laravel Nova 4 support #47

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

nicko170
Copy link
Contributor

Nova 4 has started using NovaRequest instead of request in ->actions() and ->filters(). All my tests were failing with :

App\Nova\Resources\ChangeApproval::actions(): Argument #1 ($request) must be of type Laravel\Nova\Http\Requests\NovaRequest, Illuminate\Http\Request given, called in /Users/nickp/Documents/GitHub/ixport.al/vendor/joshgaber/novaunit/src/Traits/ActionAssertions.php on line 26

@joshgaber joshgaber changed the base branch from main to release/3.0.1 April 12, 2022 01:06
@joshgaber
Copy link
Owner

Thank you for bringing this to my attention. I will need to fix up the unit tests to account for this change before I can release it. I will deploy a new version ASAP.

@joshgaber joshgaber merged commit 54820ef into joshgaber:release/3.0.1 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants