fixes #59, baseurl to resolve // issue #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied the ruleset for baseurls outlined here http://downtothewire.io/2015/08/15/configuring-jekyll-for-user-and-project-github-pages/
|
Had to open new pull as last one was completely broken |
|
@lukemcgregor Sorry for the delay, I finally got around to reviewing these PRs and merging them. Thank you for your contributions. When you get a chance can you update this PR so we can get it in. Looks like the fix will make life easier for a lot of people. Cheers! |
|
@joshgerdes try now. Thanks for making this awesome skin 👍 If you are interested heres where I'm using it: http://blog.staticvoid.co.nz/2017/migrating-my-blog-to-jekyll-and-github-pages/ |
joshgerdes
approved these changes
Aug 30, 2017
This was referenced Sep 4, 2017
adishavit
reviewed
Sep 4, 2017
|
|
||
| <link rel="stylesheet" href="{{ "css/main.css" | prepend: site.baseurl }}?{{site.time | date: '%s%N'}}"> | ||
| <link rel="stylesheet" href="{{ site.baseurl }}/css/main.css?{{site.time | date: '%s%N'}}"> |
There was a problem hiding this comment.
@lukemcgregor : this line looks for css/main.css which does not exist after this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the ruleset for baseurls outlined here
http://downtothewire.io/2015/08/15/configuring-jekyll-for-user-and-project-github-pages/