New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text_prompt): use unicode-width instead of char cnt #46
Conversation
The cursor position is not correct when there are emojis in the prompt. This PR fixes it by using unicode-width.
The cursor position is not correct, which need to be fixed in upstream dependency: joshka/tui-prompts#46
The cursor position is not correct, which need to be fixed in upstream dependency: joshka/tui-prompts#46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Hi, @joshka on a second thought I think there's no need to depend on unicode-width at all. |
|
The cursor position is not correct, which need to be fixed in upstream dependency: joshka/tui-prompts#46
I'll release shortly. Thanks for the prs |
The cursor position is not correct when there are emojis in the prompt(See the picture below). This PR fixes it by using unicode-width.