Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bindAll usage #20

Merged
merged 15 commits into from Sep 25, 2018
Merged

Fix bindAll usage #20

merged 15 commits into from Sep 25, 2018

Conversation

Khamurdik
Copy link
Contributor

_.bindAll is mutable function and doesn't return any value. Variable obj is mutated and must be returned after _.bindAll call.

_.bindAll is mutable function and doesn't return any value. Variable obj is mutated and must be returned after _.bindAll call.
@robaleman
Copy link

Thank you!

@dakebl
Copy link

dakebl commented Jul 23, 2018

@joshkatz this fixed the issue. Can you please merge this in?

@Sifogiannos
Copy link

Sifogiannos commented Aug 28, 2018

Does not seem to be merged, i dislike hardcoding this kind on thing in node_modules, what should we do @dakebl ?

@Khamurdik
Copy link
Contributor Author

You can get module directly from my GitHub by writing in your 'package.json':
"dependencies": {
"r-script": "git+https://git@github.com/khamurdik/r-script.git"
}

@Sifogiannos
Copy link

Thanks for your quick response, this approach is a bit more elegant, i would preffer a better solution through npm but i cannot as too much. I hope you do not delete the repository.

@joshkatz joshkatz merged commit b5038b0 into joshkatz:master Sep 25, 2018
@djpalumbo
Copy link

@joshkatz Are there any plans to publish this patch through NPM?

@JosephGJ
Copy link

@joshkatz I would also like to see this patch published through NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants