Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for setuptools installation #1

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

niemsoen
Copy link
Contributor

This fixes a bug when building the package as setuptools has had an update to use script_dir and install_scripts with an underscore instead of a dash (script-dir and install-scripts) now. Please see here for reference.

@joshnewans
Copy link
Owner

Thanks! I forget how, but I spotted your fork the other day and noticed your fix, I had meant to message and ask about getting a PR.

I'll merge it now and just assume it actually works. My experience with releasing ROS packages is very limited and I've been meaning for a while to properly make sure this package is available (and works!) on the foxy/galactic/humble/rolling repos, so this is a good opportunity for me to bump the version as well as get it on all the distros.

I probably won't get around to that for a week or two though.

@joshnewans joshnewans merged commit 32e0eed into joshnewans:main Jul 26, 2022
@niemsoen
Copy link
Contributor Author

niemsoen commented Aug 3, 2022

Sure, happy to help and thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants