Updated for Spree 3.0 stable branch #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,11 @@ | |||
| Spree.config do |config| | |||
| # create a list of admin emails | |||
| admin_role = Spree::Role.find_by_name('admin') | |||
| admin_emails = admin_role.users.map(&:email).join(',') | |||
| if ENV['RAILS_ENV'] == 'test' | |||
There was a problem hiding this comment.
Hey @farneman,
Feel its better to not add this to the initializer, since all sites will then have this code. Would prefer to do it in a before block in the specs.
There was a problem hiding this comment.
Maybe its better for the generator to leave all config options commented.
|
I would agree about leaving all the config options commented—thereby letting each project implement the email list source as they need to. I'll make that change and update the specs to set the config accordingly. |
|
Groovy! |
|
@joshnuss I've update the PR now. |
joshnuss
added a commit
that referenced
this pull request
Apr 1, 2015
Updated for Spree 3.0 stable branch
|
Awesomeness, thanks @farneman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.