Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save to Wallabag #44

Open
Trottel opened this issue Nov 23, 2021 · 5 comments
Open

Can't save to Wallabag #44

Trottel opened this issue Nov 23, 2021 · 5 comments

Comments

@Trottel
Copy link

Trottel commented Nov 23, 2021

After the last changes in TT RSS there is no Save to Wallabag buton nor the keyboard shortcut A+W works.

@cthu1hoo
Copy link

cthu1hoo commented Jan 1, 2022

the problem (well, there could be more, i haven't checked any further) is invalid markup in the article button hook handler:

@@ -164,7 +165,7 @@ class Wallabag_v2 extends Plugin {
                $rv = "<img id=\"wallabagImgId\" src=\"plugins.local/wallabag_v2/wallabag.png\"
                        class='tagsPic' style=\"cursor: pointer;\"
                        onclick=\"postArticleToWallabag($article_id)\"
-                       title='".__('Wallabag v2')."'>";
+                       title='".__('Wallabag v2')."'/>";

also, it looks like there's a typo which prevents this plugin from being user-loaded:

--- a/wallabag_v2/init.php
+++ b/wallabag_v2/init.php
@@ -6,6 +6,7 @@ class Wallabag_v2 extends Plugin {
                return array("2.0.0",
                        "Post articles to a Wallabag v 2.x instance",
                        "joshu@unfettered.net",
+                       false,
                        "https://github.com/joshp23/ttrss-to-wallabag-v2");
        }

@Trottel
Copy link
Author

Trottel commented Jan 1, 2022

Thank you very much @cthu1hoo , now it's working!

@joshp23
Copy link
Owner

joshp23 commented Jan 1, 2022

if you could put in a pull request I'll be happy to merge it.

@Trottel
Copy link
Author

Trottel commented Jan 1, 2022

I made a pull reguest :)

@Nikkiiw
Copy link

Nikkiiw commented Apr 17, 2022

@cthu1hoo thx a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants