Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of npdim #457

Merged
merged 2 commits into from Nov 6, 2023
Merged

get rid of npdim #457

merged 2 commits into from Nov 6, 2023

Conversation

segasai
Copy link
Collaborator

@segasai segasai commented Oct 27, 2023

This gets rid of npdim and produces a couple of deprecation warnings.

A couple of decisions I had to make -- I made sure to rename all the npdim= keywords in various classes (other than the top ones like NestedSampler and DynamicNestedSampler) to ndim=. The reason is that I prefer minimize the number of concepts/standard variable names throughout the code.
The consequence of that is that when we release this i don't quite know if restoring checkpoints from previous version will be possible. I don't think it is a big deal, but not everyone may agree.

This is followup from #456

@coveralls
Copy link

coveralls commented Oct 27, 2023

Pull Request Test Coverage Report for Build 6774895700

  • 28 of 34 (82.35%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 91.729%

Changes Missing Coverage Covered Lines Changed/Added Lines %
py/dynesty/dynesty.py 9 15 60.0%
Files with Coverage Reduction New Missed Lines %
py/dynesty/nestedsamplers.py 1 91.6%
Totals Coverage Status
Change from base Build 6655377848: -0.1%
Covered Lines: 4159
Relevant Lines: 4534

💛 - Coveralls

@segasai
Copy link
Collaborator Author

segasai commented Nov 2, 2023

I checked that the checkpoints from previous version will not be restored with this change. The error message

warnings.warn(

however is clear enough, so I don't consider that an issue.
I'll merge this soon.

@segasai segasai merged commit 9d40a8a into master Nov 6, 2023
6 checks passed
@segasai segasai mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants