feat: add scroll + fix typos #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshstevens19
approved these changes
Jul 13, 2023
|
Will deploy tomorrow thanks for PR |
Turupawn
reviewed
Jul 18, 2023
| @@ -66,6 +66,7 @@ The below networks are supported by default, and custom networks can be supporte | |||
| | Etherlite | 111 | | |||
| | Linea Testnet | 59140 | | |||
| | Linea | 59144 | | |||
| | Scroll | 534352 | | |||
There was a problem hiding this comment.
Scroll mainnet is not yet launched. This should be renamed to Scroll Alpha
| @@ -596,6 +596,7 @@ export class Multicall { | |||
| case Networks.kcc: | |||
| case Networks.lineaTestnet: | |||
| case Networks.linea: | |||
| case Networks.scroll: | |||
There was a problem hiding this comment.
Scroll Alpha multicall deployment is at 0x2117f703867a2B7E6813c7e5Edd96bf9a8d8eC30
There was a problem hiding this comment.
And also should be renamed to Networks.scrollAlpha
| @@ -50,4 +50,5 @@ export enum Networks { | |||
| etherlite = 111, | |||
| lineaTestnet = 59140, | |||
| linea = 59144, | |||
| scroll = 534352, | |||
There was a problem hiding this comment.
This should be renamed to scrollAlpha
|
@Turupawn please fix with a PR and we will merge and deploy as this has now been merged |
PriestBera
pushed a commit
to PriestBera/ethereum-multicall
that referenced
this pull request
May 18, 2024
feat: add scroll + fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add scroll + fix typos