Support ruby 3.2 fix #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades the gem to support the new `ruby3.2` runtime of which AWS says: "Ruby 3.2 adds many features and performance improvements, including anonymous arguments passing improvements, ‘endless’ methods, Regexp improvements, a new Data class, support for pattern-matching in Time and MatchData, and support for ‘find pattern’ in pattern matching. Existing Lambda customers using the Ruby 2.7 runtime should migrate to the Ruby 3.2 runtime as soon as possible. Even though community support for Ruby 2.7 has ended, Lambda has extended support for the Ruby 2.7 runtime until December 7, 2023 to provide existing Ruby customers with time to transition to Ruby 3.2. Functions using Ruby 2.7 continue to be eligible for technical support and Lambda will continue to apply OS security updates to the runtime until this date." This also changes the docker image used to build the package dependencies from the `lambci/lambda:*` images to the `amazon/aws-lambda-ruby:*` images provided and maintained by AWS. These images are the exact images used by lambda functions using a ruby runtime. They unfortunately don't have all the build dependencies present in the lambci images. Thus a wrapper script is provided around the gem packaging in a docker container that ensures the necessary packages are installed
- Rebase to get latest changes; regen yarn.lock file - Remove commented out code in integration.sh (done in rebase) - Remove documented ability to override the docker image
So that its installed with the plugin into node-modules and can be invoked from a serverless project when bundling w/native extensions.
svestu
added a commit
to svestu/serverless-ruby-package
that referenced
this pull request
Oct 11, 2023
… Allow patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits were reviewed in #50
Last commit is new and changes the following:
build-gems.shscript from the demo-service into the project root and ensures it is distributed with the npm package when releasedbuild-gems.shscript from bash in its new location.