Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails hard on hashes with / in them #48

Closed
hopeseekr opened this issue Sep 12, 2013 · 0 comments
Closed

Fails hard on hashes with / in them #48

hopeseekr opened this issue Sep 12, 2013 · 0 comments

Comments

@hopeseekr
Copy link
Contributor

Kickstart.js will die in a ball of fire if there is an element in the document with a hashtag that contains a slash (/) in it. This basically rules out happy integration with projects such as jQuery Address.

Case code that caused it to blow:

    <a href="#multitables/3">Multiplication x4</a>

Demo: http://www.phpu.cc/megadiction#/vocab/5
@hopeseekr hopeseekr mentioned this issue Sep 12, 2013
Merged
joshuagatcke added a commit that referenced this issue Sep 23, 2013
@joshuagatcke
Merge pull request #49 from hopeseekr/master
f3fc211 
Case #48: Wrap hash searching in a try/catch block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hopeseekr @joshuagatcke