Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphing Bug #53

Closed
Chobbes opened this issue Jun 19, 2022 · 3 comments
Closed

Graphing Bug #53

Chobbes opened this issue Jun 19, 2022 · 3 comments

Comments

@Chobbes
Copy link

Chobbes commented Jun 19, 2022

It seems like if you start an exercise and then restart it by hitting enter three times the graph contains a flat region of 0 WPM for the amount of time that elapsed prior to restarting the test. It seems weird to me because it looks like the page should reload whenever you reset, but I guess the beginning of the timer isn't being reset somehow?

2022-06-19T18:35:50-04:00

@JoshuaGrams
Copy link
Owner

Ah, thanks! That might explain a couple other weirdnesses I've seen with the graph but that didn't seem to actually be throwing any errors. I'll take a look. Sorry for the slow response; we're really getting into summer on the farm now...

@JoshuaGrams
Copy link
Owner

Ah, yeah. The event handler was firing when I cleared the typed text, and then it didn't check properly, so it was recording an empty "change" when you reset. So the time between resetting and when you started running it again. Which I've never noticed because I always wait to reset until I'm ready to go again.

This seems to be fixed for me now, but definitely re-open this if it's not...

@Chobbes
Copy link
Author

Chobbes commented Jun 20, 2022

Thanks! It seems to be fixed now :). I figured it might have been a clue to some of the other weird stuff I've seen too, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants