Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Commit

Permalink
Pinned the generic-pool version number to 2.1.0. Users should not not…
Browse files Browse the repository at this point in the history
…ice any breaking changes unless they are accessing the Pool.pool.acquire() with a call back that is not using (err, obj). Thanks to David Aebersold "daebersold" for pointing out the pinning.
  • Loading branch information
Joshua Heiks committed Jul 29, 2014
1 parent 90393ef commit b82c252
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions README.md
Expand Up @@ -52,7 +52,7 @@ This method will release your client object back into the pool.

### acquireHelper(errorCallback, clientCallback)
This method accepts two callbacks. The error callback is called if the pool
cannot return a client. `errorCallback(err)`. The clientCallback(client) returns the redis client connection. Note: You still need to **release** the client object.
cannot return a client. `errorCallback(err)`. The clientCallback(client) returns the redis client connection. Note: You still need to **release** the client object. *This function will be removed in the 0.2 release*

### Drain(Pool, callback)
This method will drain the connection pool completely and execute the callback when finished. You should call this when you want to close your application. If you do not your application will continue to run forever.
Expand Down Expand Up @@ -134,5 +134,6 @@ If you would like to see what the *generic-pool* module is doing your can enable
}

## Changes
* 2014-07-28 [0.1.4] - Pinned generic-pool version 2.1.0 in package.json. Thanks to David Aebersold for tagging pull request.
* 2013-09-16 [0.1.3] - Fixed a bug in how authentication is handled. Updated the documentation to reflect changes.
* 2013-03-06 - Added Unix socket support by setting the `unix_socket` option.
* 2013-03-06 - Added Unix socket support by setting the `unix_socket` option.
4 changes: 2 additions & 2 deletions package.json
@@ -1,7 +1,7 @@
{
"name": "sol-redis-pool",
"description": "Generic resource pooling for Node.JS",
"version": "0.1.3",
"version": "0.1.4",
"author": "Joshua Heiks <joshuaheiks@gmail.com>",
"keywords": ["pool", "redis"],
"main": "index.js",
Expand All @@ -10,7 +10,7 @@
"url": "git://github.com/joshuah/sol-redis-pool.git"
},
"dependencies" : {
"generic-pool" : "1.0.12",
"generic-pool" : "2.1.0",
"redis" : "*"
},
"engines": { "node": ">= 0.10.0" }
Expand Down

0 comments on commit b82c252

Please sign in to comment.