Ignore workspaces without names

joshuajaco · Jun 10, 2023 · 307781a · 307781a
1 parent 302a28b
commit 307781a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/no-absolute-imports.js b/lib/rules/no-absolute-imports.js
@@ -28,7 +28,7 @@ module.exports.create = (context) => {
   const filename = context.getFilename();
   return getImport(workspaces, filename, ({ node, path, start, end }) => {
     workspaces.forEach(({ package: { name }, location }) => {
-      if (isSubPath(location, filename) && isSubPath(name, path)) {
+      if (name && isSubPath(location, filename) && isSubPath(name, path)) {
         context.report({
           node,
           messageId: "noAbsoluteImports",

diff --git a/lib/rules/no-cross-imports.js b/lib/rules/no-cross-imports.js
@@ -88,6 +88,7 @@ module.exports.create = (context) => {
         )
         .forEach(({ package: { name }, location }) => {
           if (
+            name &&
             name !== currentWorkspace.package.name &&
             (isSubPath(name, value) || isSubPath(location, path))
           ) {

diff --git a/lib/rules/require-dependency.js b/lib/rules/require-dependency.js
@@ -27,6 +27,7 @@ module.exports.create = (context) => {
           currentWorkspace.package;
 
         if (
+          name &&
           name !== currentWorkspace.package.name &&
           (isSubPath(name, value) || isSubPath(location, path)) &&
           !Object.keys(dependencies).includes(name) &&

diff --git a/tests/mocks.js b/tests/mocks.js
@@ -38,6 +38,12 @@ module.exports.findWorkspacesMock = () => [
       name: "@test/scoped-workspace",
     },
   },
+  {
+    location: "/test/undefined-workspace",
+    package: {
+      name: undefined,
+    },
+  },
   {
     location: "root",
     package: { name: "root" },

diff --git a/tests/rules/no-absolute-imports.js b/tests/rules/no-absolute-imports.js
@@ -40,6 +40,10 @@ describe("no-absolute-imports", () => {
         code: "import workspace from '@test/workspace';",
         filename: "/some/path.js",
       },
+      {
+        code: "import '@test/undefined-workspace';",
+        filename: "/test/undefined-workspace/some/path.js",
+      },
     ],
 
     invalid: [