Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!programs Changes #8

Closed
joshuajz opened this issue Mar 2, 2021 · 0 comments
Closed

!programs Changes #8

joshuajz opened this issue Mar 2, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@joshuajz
Copy link
Owner

joshuajz commented Mar 2, 2021 •
edited
Loading

  1. Changing !programs_add. Instead it will start to add on to the previous list of programs. If the user already has a !programs, they can add more with !programs_add "University of Github"
  2. !programs @USER will now list out the programs with a number beside each one.
    ie.:
1. University of Github
2. University of A
3. University of B

  1. Changing !programs_remove. Instead you can remove a specific program with !programs_remove 1 OR you can remove them all with !programs_remove *

  2. Changes to the database: Descriptions will no longer be actual python lists, instead we will change to a _\n\n version.
    ie.:
    Program 1\nProgram 2\nProgram 3
    We can then split with the \n

  3. Fix to !programs_add, where if the user puts the first program on a newline, it doesn't work.
    image

Though the bot could've been down for this period of time. Furthur bugtesting is needed.
@joshuajz joshuajz added bug Something isn't working enhancement New feature or request labels Mar 2, 2021
joshuajz added a commit that referenced this issue Mar 13, 2021
@joshuajz
Updated Readme/Programs
6210a2e 
- Readme updated to reflect the new environment variables
- close #5 -> Fixed the bug where a user @s themself with !programs and it adds their username as a program
- #8
    - !programs_add has been updated to be able to just add to the DB
    - !programs now prints out with numbers before each program
    - Database changes -> Now it's each program followed by a newline
joshuajz added a commit that referenced this issue Mar 14, 2021
@joshuajz
Working on #8
42cdec9 
- !programs_remove getting numbers
- TODO: Add try-except for each value being added
joshuajz added a commit that referenced this issue Mar 23, 2021
@joshuajz
Almost finished with editing for !programs (#8)
2e3bb79 
- !programs_edit almost finished (just need reaction handling)
- !programs_add -> uses new database structure and fixed bug where it would error if you didn't already have a !programs
- programs database uses \n instead of the eval list format from python
- programs_handling now is formatted better, and deletes the message sooner to ensure there aren't any double additions
  - Also, has split sections for both types (editing and adding)
- fixed a bug in programs_deletion where if you used: !programs_remove 1, just n - 1 to add the "1" back in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuajz