Child device support #2
Conversation
adamkempenich
commented
Feb 19, 2020
adamkempenich
commented
- Added child devices for relays and backlight
- Added logDescriptionText and logDebugText options
- Added importURL
- Added option to turn screen on when proximity falls below a value
- Added child devices for relays and backlight - Added logDescriptionText and logDebugText options - Added importURL - Added option to turn screen on when proximity falls below a value - Added option to turn on the above option
|
Hey @adamkempenich did you get the notifications for the minor comments I added to the PR? If not, I can go ahead and just merge the PR as-is since the suggestions were really minor about uncommenting the metadata definitions for the various toggle commands that you filled in. Edit: Whoops. I might have just discarded them:
|
There was a problem hiding this comment.
Code looks and works good. Couple of minor comments
May be add in
capability "Configuration"
Then from the configure method you should be able to check to see if the child devices exist and if not create them like what you have done in the installed method. This should add them to an existing device in that case. Also on the labels for the component may be preference them with Wink Relay, this way they should be in the same location as the Wink in the dashboard list.
Also the proximity logic should support a delay capability. That way the code does nto cause the device to flash on and off.
| def checkProximity(){ | ||
| if(device.currentValue('proximity') >= settings.screenOnProximity){ | ||
| screenBacklightOn() | ||
| } else{ screenBacklightOff() } |
There was a problem hiding this comment.
It might be good here to place a delay on this action. This would be in line with the original wink. At the moment this seems to flash on and off so the logic could benefit from a delay capability on here.
I've been mostly AFK the last week or so. I will add a configure/child device check, along with the delay, and resubmit. |
|
Thanks for your contribution @adamkempenich 👍 I've gone ahead and merged the PR. |
|
Thank you! |
