fix(agent): 🐛 don't bail on registration if no preferences file was f…

…ound but default preferences were returned

internal/agent/register.go

@@ -10,7 +10,6 @@ import (
 	"errors"
 	"fmt"
 	"net/url"
-	"os"
 
 	"github.com/rs/zerolog/log"
 
@@ -103,7 +102,7 @@ func (agent *Agent) performRegistration(ctx context.Context) error {
 
 func (agent *Agent) checkRegistration(trk SensorTracker) error {
 	prefs, err := preferences.Load()
-	if err != nil && !os.IsNotExist(err) {
+	if err != nil && !errors.Is(err, preferences.ErrNoPreferences) {
 		return fmt.Errorf("could not load preferences: %w", err)
 	}
 

internal/preferences/prefs.go

@@ -8,6 +8,7 @@
 package preferences
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -39,6 +40,9 @@ var (
 var (
 	preferencesPath = filepath.Join(xdg.ConfigHome, "go-hass-agent")
 	preferencesFile = "preferences.toml"
+
+	ErrNoPreferences = errors.New("no preferences file found, using defaults")
+	ErrFileContents  = errors.New("could not read file contents")
 )
 
 //nolint:tagalign
@@ -273,12 +277,12 @@ func Load() (*Preferences, error) {
 
 	b, err := os.ReadFile(file)
 	if err != nil {
-		return prefs, fmt.Errorf("could not read preferences file: %w", err)
+		return prefs, errors.Join(ErrNoPreferences, err)
 	}
 
 	err = toml.Unmarshal(b, &prefs)
 	if err != nil {
-		return prefs, fmt.Errorf("could not parse preferences file: %w", err)
+		return prefs, errors.Join(ErrFileContents, err)
 	}
 
 	return prefs, nil