Initial work

[joshuataylor]

Read the README for a rundown. This is a port from snowflake_elixir so some of it might be a bit weird to get it into the req approach.

You can signup for a 30 day trial for snowflake here, I can also provide a test account if you contact me on slack (@joshx on Elixir Slack) or email me (email in bio).

Right this only supports JSON, I see there is now a Rustler library for handling Arrow, I'll have to try it as the last time I played with it they had issues with some of the non-standard types Snowflake had (I think it was around decimals or timestamps from memory, I'll need to double check).

Please give as much feedback as you need to make this a great project for the community.

For some reason, running mix test fails, but running each test file works. I'll look into this tomorrow.

Once we get this in, we'll add the following:

• Add async queries back, and add option to poll for response
• Document the different insert types
• Add support for caching the token for the user/password/role, with default as true
• Add support for session parameters in Snowflake
• Document the library thoroughly
• Add support to snowflake_elixir_ecto using this library, it should be very straight forward as it already works with snowflake_elixir.
• Add CI support

[wojtekmach]

This is really great to see! I did a first pass focusing on Req usage. Didn't pay too much attention to snowflake bits as I don't have any experience with them anyway yet. Hope it helps!

[wojtekmach]

consider returning non-successful responses as is. If your users do Req.new(http_errors: :raise), Req will raise the exception.

[joshuataylor]

Do you mean without the RuntimeError?
ie:

  defp decode_response(%Req.Response{body: %{"message" => message}}),
    do: message

or returning the actual response?

  defp decode_response(%Req.Response{body: %{"message" => _message}} = response),
    do: RuntimeError.exception(response)

[wojtekmach]

oh, actually we could even do something else. Have just this one clause as is:

defp decode_response(%Req.Response{status: 200, body: %{"data" => %{"token" => token}}}),
     do: token

but then make this change at the callsite:

- Req.post!(url, json: data)
+ Req.post!(url, json: data, http_errors: :raise)
  |> decode_response()

that is, if we got 4xx/5xx, Req will raise an exception with the (decoded) response body included in the message. On successful response, we'd call decode_response/1.

WDYT?

Of course if you want a custom error message, what you have is the way to go.

[joshuataylor]

I like it, the main reason I did it the other way was because we can expose the error message Snowflake gives back to us, but for a client like this it's fine (because we should be giving back errors IMHO). That should be the responsibility the user or snowflake_elixir (db_connection) or whatever.

[joshuataylor]

I've got a bunch of features coming in the next day or so to merge in, last few days I have been looking more into Arrow and supporting that.

Also, in exciting news -- PR here for snowflake_arrow, which uses Rustler and arrow2 to decode Arrow files.