Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on non-200 response codes. #25

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fail on non-200 response codes. #25

merged 1 commit into from
Jan 9, 2023

Conversation

robdimsdale
Copy link
Collaborator

  • no test added for github releases as there is no existing test framework for this.

@robdimsdale
Fail on non-200 response codes.
10bd646 
- no test added for github releases as there is no existing test framework for this.
@robdimsdale robdimsdale mentioned this pull request Jan 9, 2023
Open
@robdimsdale
Copy link
Collaborator Author

@joshuatcasey the lint check is failing for a pre-existing reason:

Error: tests: ExampleLogAllVersions_OneVersion refers to unknown field or method: LogAllVersions.OneVersion (govet)

I'd like to get this PR merged with that pre-existing issue if possible, but if you need to address this lint issue we can have that conversation here.

@joshuatcasey joshuatcasey added the semver:minor A change requiring a minor version bump label Jan 9, 2023
@joshuatcasey joshuatcasey merged commit 71b46e8 into joshuatcasey:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robdimsdale @sophiewigmore @joshuatcasey