Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Licenses and certifications #59

Closed
eNzyOfficial opened this issue Nov 7, 2021 · 3 comments
Closed

Missing Licenses and certifications #59

eNzyOfficial opened this issue Nov 7, 2021 · 3 comments
Assignees
Labels
bug Something isn't working regression

Comments

@eNzyOfficial
Copy link

eNzyOfficial commented Nov 7, 2021

It seems like it's not pulling this information from the profile, would it be possible to add this to the data?

An example profile containing this section would be:
https://www.linkedin.com/in/devashish-katoriya-84699337

EDIT: Seems like it's not pulling the languages out either, only the first one

@joshuatz joshuatz self-assigned this Nov 8, 2021
@joshuatz joshuatz added bug Something isn't working regression labels Nov 8, 2021
joshuatz added a commit that referenced this issue Nov 8, 2021
 - Extract language proficiencies (profile section), and combine with
 main profile default locale (might lead to duplicates, but this kind
 of unavoidable)
joshuatz added a commit that referenced this issue Nov 8, 2021
 - With the transition to `v1` of the schema, certificates did not get
 updated to be included in the `stable` / v1 schema by default. Fixed.
 - Fix for #59
@joshuatz
Copy link
Owner

joshuatz commented Nov 8, 2021

Both issues (Certifications + Languages) are now fixed in the v3.1.0 release.

Thanks for bringing this to my attention!

@joshuatz joshuatz closed this as completed Nov 8, 2021
@eNzyOfficial
Copy link
Author

eNzyOfficial commented Nov 8, 2021

@joshuatz Sorry to reopen this one.

https://www.linkedin.com/in/punika1988/

Not sure what the edge case is but it seems on this profile it doesn't pull all the languages. However the profile in the OP seems to work fine.

Also, thanks for the extremely fast fix!

@joshuatz
Copy link
Owner

@eNzyOfficial No worries; I appreciate the follow up and bringing the edge-case to my attention. I had missed a different way that LinkedIn was nesting the language data - now fixed in the v3.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

No branches or pull requests

2 participants