Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any roadmap / plan / collaboration? #14

Open
ghost opened this issue Jan 31, 2018 · 2 comments
Open

Any roadmap / plan / collaboration? #14

ghost opened this issue Jan 31, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 31, 2018

Are there any Road map or plan to move forward IBrokers package?

Are there any way to collaborate with this project?

@joshuaulrich
Copy link
Owner

joshuaulrich commented Feb 26, 2018

Hi Mario,

The situation with this package is that the original author, Jeffrey Ryan, is somewhat restricted from contributing to open-source projects by his current employer. I maintain the package but I don't actively use it. I'm also extremely time-constrained between my responsibilities to my employer, family, and other open-source projects.

The PR you linked to has many issues that prevent me from evaluating the functional changes. It also includes changes that violate the CRAN Repository Policy. That's why it hasn't been merged, and is unlikely to be merged.

Regarding a roadmap: I would love to upgrade the package to use the most up-to-date client version. I also have many private emails that contain feature requests and/or questions about how to use the package. I need to submit these as issues on this tracker, so others can contribute to their resolution. I would also love to have unit tests, possibly using mocks of the TWS API.

Regarding collaboration: I don't know the API extremely well, so I need well-documented patches/pull-requests, preferably with links to the official API documentation and/or implementations in other languages. The changes in the PR should be minimal, and should include commit messages that explain what changed and why. The PR section of the contributing guide I use in my other projects has some things that help make the process easier.

Thanks for reaching out, and I hope my response helps!

@vspinu
Copy link
Contributor

vspinu commented Jun 23, 2022

I have just made public rib which is a full featured client based on the official cppclient, thus 100% feature complete by design. I personally think that's the way forward. The disadvantage is that it cannot be released to CRAN because the the tws-api commercial licence and an extra step of downloading the offical code required by the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants