-
-
Notifications
You must be signed in to change notification settings - Fork 219
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2 from joshuaulrich/master
bring fork up to date
- Loading branch information
Showing
25 changed files
with
858 additions
and
1,057 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,5 +7,7 @@ WISHLIST | |
^\.git | ||
^\.gitignore | ||
^.*\.orig$ | ||
^.*\.md$ | ||
^README.md$ | ||
^CONTRIBUTING.md$ | ||
^CRAN_comments.md$ | ||
.travis.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Regarding the NOTE about the calls to attach(): | ||
The calls to attach() are made in the function attachSymbols(). This function is a mechanism to wrap the complexity of attaching multiple symbols (a database of potentially thousands of individual instrument names) with one simple call. Based on previous emails with CRAN regarding this specific attach usage, and the lack of anything beyond the NOTE 'finding' the call, this seems well within the scope of behavior required by CRAN. Note that the name of the function doing this attach is an extension of the attach name itself, which makes the function's purpose clear. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.