Skip to content

Commit

Permalink
Merge pull request #2 from joshuaulrich/master
Browse files Browse the repository at this point in the history
bring fork up to date
  • Loading branch information
ethanbsmith committed Sep 23, 2018
2 parents b0ab966 + a8e9cb8 commit 9cf41d9
Show file tree
Hide file tree
Showing 25 changed files with 858 additions and 1,057 deletions.
4 changes: 3 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ WISHLIST
^\.git
^\.gitignore
^.*\.orig$
^.*\.md$
^README.md$
^CONTRIBUTING.md$
^CRAN_comments.md$
.travis.yml
133 changes: 0 additions & 133 deletions CHANGES

This file was deleted.

3 changes: 3 additions & 0 deletions CRAN_comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Regarding the NOTE about the calls to attach():
The calls to attach() are made in the function attachSymbols(). This function is a mechanism to wrap the complexity of attaching multiple symbols (a database of potentially thousands of individual instrument names) with one simple call. Based on previous emails with CRAN regarding this specific attach usage, and the lack of anything beyond the NOTE 'finding' the call, this seems well within the scope of behavior required by CRAN. Note that the name of the function doing this attach is an extension of the attach name itself, which makes the function's purpose clear.

7 changes: 4 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
Package: quantmod
Type: Package
Title: Quantitative Financial Modelling Framework
Version: 0.4-11
Date: 2017-10-06
Version: 0.4-13.1
Date: 2018-04-10
Authors@R: c(
person(given=c("Jeffrey","A."), family="Ryan", role=c("aut","cph")),
person(given=c("Joshua","M."), family="Ulrich", role=c("cre","aut"), email="josh.m.ulrich@gmail.com"),
person(given="Wouter", family="Thielen", role="ctb"),
person(given="Paul", family="Teetor", role="ctb")
person(given="Paul", family="Teetor", role="ctb"),
person(given="Steve", family="Bronder", role="ctb")
)
Depends: R (>= 3.2.0), xts(>= 0.9-0), zoo, TTR(>= 0.2), methods
Imports: curl
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ export(
getSymbols.yahoo,
getSymbols.yahooj,
getSymbols.oanda,
getSymbols.tiingo,
#getSymbols.Bloomberg,
#getSymbols.IBrokers,
getSymbols.csv,
Expand Down
Loading

0 comments on commit 9cf41d9

Please sign in to comment.