Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_TA legend argument cannot be set #205

Closed
helgasoft opened this issue Dec 5, 2017 · 1 comment
Closed

add_TA legend argument cannot be set #205

helgasoft opened this issue Dec 5, 2017 · 1 comment

Comments

@helgasoft
Copy link

helgasoft commented Dec 5, 2017

Description

I appears the legend argument of add_TA cannot be changed from default 'auto' to a custom string.

Expected behavior

I hoped add_TA would work like the standard function addTA.

Minimal, reproducible example

getSymbols('T')
chartSeries(T); addTA(EMA(Cl(T)), legend="myEMA")	# does it ok
chart_Series(T); add_TA(EMA(Cl(T)), legend="myEMA") 	   # doesn't
@joshuaulrich
Copy link
Owner

This is addressed by the fix for #377. That fix adds a name argument and removes the legend argument. The rationale is:

I tried to pass user-supplied 'legend' values through the plotting functions, but it didn't work seamlessly like it does when passing the 'name' argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants