Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name argument to add_TA #377

Closed
SamoPP opened this issue Apr 3, 2023 · 2 comments
Closed

Add name argument to add_TA #377

SamoPP opened this issue Apr 3, 2023 · 2 comments
Labels
enhancement
Milestone
Release 0.4.23

Comments

@SamoPP
Copy link

SamoPP commented Apr 3, 2023

Description

It would be nice to have a name argument in add_TA function (instead of lenv$name <- deparse(substitute(x))).

Expected behavior

Instead of using lenv$name <- deparse(substitute(x)) function argument name (if set, not NULL) would be used.

Minimal, reproducible example

[Insert your sessionInfo() output]
@joshuaulrich joshuaulrich added this to the Release 0.4.23 milestone Apr 16, 2023
@joshuaulrich
Copy link
Owner

I just noticed that this is similar to #205. add_TA() and add_Series() have a legend argument to set the name. I'm going to update this fix to remove the name argument it added and make the fix using the legend argument.

@joshuaulrich joshuaulrich reopened this Apr 16, 2023
@joshuaulrich
Copy link
Owner

I changed my mind. I tried to pass user-supplied 'legend' values through the plotting functions, but it didn't work seamlessly like it does when passing the 'name' argument. So I'm keeping this fix instead of doing what I said in my previous comment.

joshuaulrich added a commit that referenced this issue Apr 16, 2023
@joshuaulrich
Remove 'legend' arg from add_TA() and add_Series()
613312e 
The 'legend' argument only supported the "auto" value. I tried to pass
user-supplied 'legend' values through the plotting functions, but it
didn't work seamlessly like it does when passing the 'name' argument.

Move the 'name' argument to the location of the 'legend' argument to
handle the case where the user explicitly provided "auto" as an unnamed
value for the 'legend' argument. For example:

    add_TA(x, NULL, NA, "auto")

See #377.
@joshuaulrich joshuaulrich mentioned this issue Apr 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 0.4.23
Development

No branches or pull requests
2 participants
@joshuaulrich @SamoPP