Update getQuote.R #223
Merged
Update getQuote.R #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #213 |
|
@joshuaulrich Im still new at this whole github thing, but it looks to me like the CI test is failing on a google getSymbols call. At this point Im not sure what to do, so will wait for your input. thx. |
|
It's not you, it's Google. I'll re-run this build. |
Alpha Vantage added support for current price quotes from multiple symbols in January, 2017. It is similar to getQuote() from Yahoo, and also provides real-time quotes (vs Yahoo's delayed data). The API only handles up to 100 symbols. And the output is slightly different from the Yahoo version. The single-ticker API includes timestamp, symbol, price, and volume; the multi-ticker API only includes timestamp, symbol, and price. Where Yahoo has a couple dozen potential columns, and is the same for one or more tickers. Fixes #213.
|
@ethanbsmith can you please give me permission to push to the PR branch in your forked repository? See, "Allowing changes to a pull request branch created from a fork". You branched from the commit after v0.4-11, so I have rebased the branch and squashed the 3 commits. We can close this PR as "merged" if I can push to the PR branch, but will be marked as "closed" if I merge my local branch. |
|
should be good. let me know if u need anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for AV batch quotes by extending getQuote with getQuote.av