getSymbols.yahooj infinite loop if symbol has no data

[joshuaulrich]

There's a potential for an infinite loop if getSymbols.yahooj is called on a symbol that has no data. For example, getSymbols("foo", src="yahooj"). The patch below seems to fix the issue.

diff --git a/R/getSymbols.R b/R/getSymbols.R
index 304dc80..a4dc742 100644
--- a/R/getSymbols.R
+++ b/R/getSymbols.R
@@ -388,13 +388,18 @@ function(Symbols,env,return.class='xts',index.class="Date",

                 fdoc <- XML::htmlParse(tmp)
                 rows <- XML::xpathApply(fdoc, "//table[@class='boardFin yjSt marB6']//tr")
-                if (length(rows) == 1) break
+                if (length(rows) <= 1) break

                 totalrows <- c(totalrows, rows)
                 page <- page + 1
             }
             if(verbose) cat("done.\n")
-            
+
+            if (is.null(rows)) {
+              warning("No historical data for ", Symbols[[i]], ", skipping...")
+              next
+            }
+
             # Available columns
             cols <- c('Open','High','Low','Close','Volume','Adjusted')

@wthielen what do you think?

[wthielen]

Looks good to me, @joshuaulrich. Checked the source for such a page, and indeed there is no table matching that xpath.
I think we need a better method to check for historical data, but then I'd need a company that is going IPO and is registered, but does not have any historical data, to see what totalrows looks like then.