Refactor dropTA to use panel functionality #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since S4 method and chartSeries.chob are deprecated, dropTA, listTA and get.chob functions are refactored to use panel functionality of xts::plot.xts. The way TAs are removed is based on which frame they are added to.
erichung0404
force-pushed
the
refactor_TA_setup_functions
branch
from
49ec234
to
8fb26c5
Compare
To reduce memory usage temporary storage is dropped and "replace()" function is applied to re-order TAs and function calls instead. actions and y limits are re-ordered according to the frames.
In addition to the movement of TA, function calls and actions are re-ordered as well.
When "ta" is not characters of functions from TTR (SMA, BBands, ...), shading regime or new series are added if "ta" is logic or an object of xts class, respectively.
erichung0404
force-pushed
the
refactor_TA_setup_functions
branch
from
808e0f8
to
ce7cad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since S4 method and chartSeries.chob are deprecated, dropTA, listTA and
get.chob functions are refactored to use panel functionality of xts::plot.xts
and coordinate with the refactored chartSeries and add* functions.
The way TAs are removed is based on the frame they are added to.
If an indicator is drawn on the price series,
frame=2orframe=-2, for example,its action will be set to NULL; otherwise
plot_object$remove_frame()is called toremove the new frame created by the indicator and reset
asp.