279 get quote resillience 2 #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explicitly call curl::curl. for some unknown reasosn the direct call to fromJSON causes erros with long symbol lists
moved coumn name and missing row handling into master function
added test for batch size and correct row labeling
Also fix typo in Tiingo column name and address whitespace/formatting.
fixed column name
|
Is the "Update getQuote.R" commit message subject is something that GitHub is automatically doing for you? I prefer that commit messages use this format, where the subject briefly (in ~50 characters) describes what will happen if the commit is applied. |
|
probably a github desktop https://desktop.github.com thing. I will watch out for that. apologies |
This reverts commit 5ff4cd6.
|
This is merged, even though GitHub says it's "Closed". I squash-merged from the command line and pushed... assuming it would do the same thing GitHub does. That's what I get for trying not to use the web interface, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getQuote would fail if the source did not recognize any of the supplied symbols. this was particularly problematic on large batches where a single failure would cause a stop and there was no way to diagnose which symbol had caused the problem
All getQuote paths now return NA rows for missing quotes
centralized row name and missing row handling into master
added explicit curl calls as direct fromJSON calls sometimes failed on long symbol lists