289 add adjusted to output #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaulrich
added a commit
that referenced
this pull request
Jan 9, 2022
This reverts commit 925efe3.
joshuaulrich
pushed a commit
that referenced
this pull request
Jan 9, 2022
Add adjusted close to output with unadjusted data, following the Yahoo pattern. This exposes both the adjusted and unadjusted data in a way that is compatible with other existing sources. It doesn't break any existing contract (both implied and specified) and doesn't require a radical re-design of the getSymbols() API. Closes #345. See #289.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the adjusted close to output with unadjusted data, following the yahoo pattern
this is the simplest approach i could think of that exposes both the adjusted and unadjusted data in a way that is compatible with other existing sources, doesnt break any existing contract (both implied and specified) and doesnt require a radical re-design of the API.
partially addresses #289