Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shift.time issue #268 #273

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

pverspeelt
Copy link
Contributor

added S3method(shift.time, xts) to the namespace.

Calling methods(shift.time) now returns [1] shift.time.xts*

Running the following code will now work for xts objects.

df1 <- data.frame(dates = Sys.time() + 1:10, 
                  values = 1:10)

df1_xts <- xts(df1$values, order.by = df1$dates)
shift.time(df1_xts, n = 60)

The shift.time() generic is exported, but the shift.time.xts() method
is not registered. Add xts S3method for shift.time to the namespace.

Fixes joshuaulrich#268.
@joshuaulrich
Copy link
Owner

I reworded the commit message to align with the commit messages section of the contributing guide. The Git commit message is much more important to me than the PR message on GitHub. The commit message is part of the repository, and exists independently of the hosting platform (e.g. GitHub, GitLab, Bitbucket, etc), while the PR message is specific to GitHub.

@joshuaulrich joshuaulrich added this to the 0.11-2 milestone Oct 6, 2018
@joshuaulrich joshuaulrich merged commit 7926ef9 into joshuaulrich:master Oct 6, 2018
@pverspeelt pverspeelt deleted the 268_fix_shift.time branch October 6, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants