Add tests #13
Add tests #13
Conversation
|
gonna close this one as it looks like this will not be merged in - let me know if you want me to re-open. thanks |
There was a problem hiding this comment.
Looks great! Sorry that this sat for so long :(
It looks like there are some conflicts, since the other PR I merged makes similar changes. The conflicts seem easy enough to resolve (the first two are just Git being weird about end-of-file newlines), but let me know if you want to tackle them. The only thing I'm not sure about is how to resolve the conflicts in the lockfiles; my general approach is to just delete and regenerate them, but them you lose the benefits of dependency version locking.
But yeah, I'm happy to commandeer and get this landed. Really appreciate the work, and sorry again about the humongous delay!
(As an aside, we should probably delete package-lock.json and just use Yarn, or vice-versa. Didn't mean to wind up with both)
| done(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This suite feels a bit to me like it's testing echo rather than anything written in userland. Just curious, in what situation would we worry about this failing? Windows, maybe? If so, maybe we should log something to console.error to explain.
| @@ -0,0 +1,52 @@ | |||
| const path = require('path'); | |||
| const execa = require('execa'); | |||
There was a problem hiding this comment.
Never heard of this dep, but it sounds interesting! child_process is a pain to work with.
This includes the changes in - #12
Adds a very basic test suite, will only work on Linux/macOS but should serve as a starting point for developers coming in.