Fix/106 #111
Merged
Fix/106 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwcomeau
commented
Dec 4, 2016
| removeNodeFromDOMFlow(childData); | ||
| if (childData.boundingBox) { | ||
| removeNodeFromDOMFlow(childData); | ||
| } |
There was a problem hiding this comment.
The obvious solution here is to just recalculate the bounding box if it's missing. Sadly, this doesn't work, for reasons I don't understand or have time to dig into; it does recalculate the bounding boxes, but it causes the elements to reshape in weird ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
(although it's really more of a band-aid than a proper fix)