Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json data to GET request body #36

Merged
merged 3 commits into from
May 30, 2020

Conversation

obuhovsergai
Copy link
Contributor

why the request can not contain body with json data, but _httpRequest contains it?

@jossef
Copy link
Owner

jossef commented May 26, 2020

@obuhovsergai

the request does not contain body/json on purpose.

In my opinion, using body in GET http requests is not well supported by most common http servers/clients.
see - https://stackoverflow.com/questions/978061/http-get-with-request-body

However, If you need this feature, you have your reasons.

version will be bumped this Friday

lib/src/requests.dart Show resolved Hide resolved
lib/src/requests.dart Show resolved Hide resolved
obuhovsergai and others added 2 commits May 27, 2020 22:37
Co-authored-by: Jossef Harush <jossef12@gmail.com>
Co-authored-by: Jossef Harush <jossef12@gmail.com>
@jossef jossef merged commit 64992bd into jossef:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants