Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unsuitable logger #66

Merged
merged 1 commit into from
May 9, 2022

Conversation

sehnryr
Copy link
Collaborator

@sehnryr sehnryr commented May 9, 2022

Proposed changes

Removes the unsuitable logger.

Type of changes

What types of changes does your code introduce?

Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • My code follows the Dart coding convention
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary documentation (if appropriate)

Further comments

The sole purpose of the logger was to log if there was an error when trying to get a cookie from storage, and I don't think this is more pertinent than an exception.

@sehnryr sehnryr marked this pull request as ready for review May 9, 2022 08:22
@sehnryr sehnryr changed the title refactor: remove useless logger refactor: remove unsuitable logger May 9, 2022
@sehnryr sehnryr merged commit 57f7c95 into jossef:master May 9, 2022
@sehnryr sehnryr deleted the remove-useless-logger branch May 9, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant