Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add addCookie method #77

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Conversation

sehnryr
Copy link
Collaborator

@sehnryr sehnryr commented Jun 16, 2022

Proposed changes

Add addCookie method to add a cookie to a CookieJar without exposing cookie.dart.

Fixes #76.

Type of changes

What types of changes does your code introduce?

Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • My code follows the Dart coding convention
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary documentation (if appropriate)

Further comments

Also fixed types that didn't get updated with 4.3.0 in the README while changing the example for the cookies.

@sehnryr sehnryr marked this pull request as ready for review June 16, 2022 20:24
@sehnryr sehnryr merged commit 6d4063e into jossef:master Jun 16, 2022
@sehnryr sehnryr deleted the 76-add-cookie-method branch June 16, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create function to manually add cookies
1 participant