Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changed the hostname parameter of the cookie management methods by the corresponding url. This will allow a better readability and a better use of these methods.
To:
This was discussed there #76 (comment) and to explain quickly here,
getHostname(url)
isn't really needed and complexify the use of the other methods unnecessarily.Type of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply.Checklist
Further comments
It would be nice to be able to pass either the url or the hostname in the methods.