Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create files for each theme #86

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

sehnryr
Copy link
Collaborator

@sehnryr sehnryr commented Oct 13, 2022

Proposed changes

+ lib/src/cookie_jar for CookieJar
+ lib/src/exception.dart for every custom Exceptions
+ lib/src/storage.dart for the CookieJars storage

- lib/src/response_error.dart

Type of changes

What types of changes does your code introduce?

Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • My code follows the Dart coding convention
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary documentation (if appropriate)

Further comments

@sehnryr sehnryr merged commit 4a0ff44 into jossef:master Oct 13, 2022
@sehnryr sehnryr deleted the dev/youn/cookie-refactor branch October 13, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant