Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "srcSet" prop is inconsistent #203

Closed
kripod opened this issue Jan 31, 2018 · 2 comments
Closed

The "srcSet" prop is inconsistent #203

kripod opened this issue Jan 31, 2018 · 2 comments

Comments

@kripod
Copy link
Contributor

kripod commented Jan 31, 2018

While preloading images, the srcSet prop is being treated as a single string, but when rendering, it is treated as an array of strings.

I think it would be better to use single strings instead of arrays to follow the standard notation of srcSets, but in order not to break backwards compatibility, dynamic type checking should be used.

kripod added a commit to kripod/react-images that referenced this issue Jan 31, 2018
@jossmac jossmac closed this as completed in 5ce37ad Feb 1, 2018
@kripod
Copy link
Contributor Author

kripod commented Feb 1, 2018

@jossmac I think this should not be closed yet, because single strings still cannot be used instead of string arrays for srcSet.

@neptunian
Copy link
Collaborator

this probably should not have been merged, as this merge was pending and would have resolved the issue #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants