Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findDOMNode is Deprecated #41

Closed
ssylvia opened this issue Mar 21, 2019 · 2 comments · Fixed by #52
Closed

findDOMNode is Deprecated #41

ssylvia opened this issue Mar 21, 2019 · 2 comments · Fixed by #52

Comments

@ssylvia
Copy link

ssylvia commented Mar 21, 2019

Looks like this library uses findDOMNode internally.

This is now deprecated in React and throws a warning when running in StrictMode: https://reactjs.org/docs/strict-mode.html#warning-about-deprecated-finddomnode-usage
@yankuanz yankuanz mentioned this issue Sep 17, 2019
Closed
@yankuanz
Copy link

The dependency react-node-resolver is using findDOMNode:

https://github.com/jossmac/react-scrolllock/blob/master/src/TouchScrollable.js#L4

https://github.com/jossmac/react-node-resolver/blob/master/src/NodeResolver.js#L4

Just created an issue in that repo.

@jossmac jossmac mentioned this issue Nov 24, 2019
Merged
@jossmac
Copy link
Owner

jossmac commented Nov 24, 2019

Changes described in #52 available in 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "react-node-resolver" jossmac/react-scrolllock
3 participants
@ssylvia @jossmac @yankuanz