Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "react-node-resolver" #52

Merged
merged 1 commit into from
Nov 24, 2019
Merged

Conversation

jossmac
Copy link
Owner

@jossmac jossmac commented Nov 24, 2019

This is a breaking change because we can no-longer assume safe ref resolution within consumer applications. TouchScrollable (and by composition ScrollLock) now support function or element children:

type ChildrenType = Element<*> | ElementRef<*> => Element<*>

If a function is provided the ref is passed in as the only argument, otherwise we clone the child with the ref.

Resolves #41

TouchScrollable (and by composition ScrollLock) now supports function or element children
@jossmac jossmac merged commit 09bb3be into master Nov 24, 2019
@jossmac jossmac deleted the break/alternate-ref-handling branch November 24, 2019 06:53
This was referenced Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findDOMNode is Deprecated
1 participant