-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content shifting when opening and closing lightbox #7
Comments
See pull request #8 |
A work around is to set the prop explicitly. |
@jorrit yes but would require the user to modify the Lightbox.js source file. |
@jossmac can we get this published on npm please :) |
I have this same issue. Layout in react-photo-gallery looks great on load (I am also using a Lightbox). Clicking on an image opens the Lightbox and I can see the layout through the overlay still looking nice. Then I close the Lightbox and the scroll bar breaks the layout and the images wrap to the next row. If I reopen the Lightbox, the layout in react-photo-gallery looks normal again. |
OK - I had a container div with a percentage width |
Due to this recent commit:
99f54ed
The defaultProps prop is being defined incorrectly and therefore
if (this.props.preventContentJumping) {
will evaluate to undefined/false and content will shift instead of defaulting to not shifting.
The text was updated successfully, but these errors were encountered: