Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deps. #29

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Add missing deps. #29

merged 3 commits into from
Jun 7, 2018

Conversation

treshugart
Copy link
Contributor

@treshugart treshugart commented Jun 7, 2018

I found a missing dep. I assumed you meant to add this as a standard dep (as opposed to peer). It was previously a dev dep.


Edit: It's not used, so I've removed.

package.json Outdated
"webpack-dev-server": "^3.1.3"
}
}
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohgod did windows do this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably prettier, it really messes with package.json

@jossmac jossmac merged commit 7b141a7 into jossmac:master Jun 7, 2018
@jossmac
Copy link
Owner

jossmac commented Jun 7, 2018

Nice catch, thanks @treshugart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants