Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when elements they lose their ref inside TouchScrollable #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nedomas
Copy link

@Nedomas Nedomas commented Jul 15, 2021

Posting it here just to check if anybody else had a problem with disappearing refs inside TouchScrollable.

An error with undefined this.scrollableArea in this.scrollableArea.removeEventListener started happening when I've started using React Suspense with React Router DOM. In certain scenarios if you load a route with Suspense on it, TouchScrollable sometimes loses this.scrollableArea value.

Not sure if there's something esoteric happening inside Suspense or there's something else - could not figure out. Was wondering if anybody else had a similar problem?

The diff here is just something that fixed my issue, but might be introducing some other problems later down the road.

Anyways - thanks for an amazing package!

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2021

⚠️ No Changeset found

Latest commit: fa2dbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nedomas Nedomas changed the title Handle when elements they disappear without unmounting Handle when elements they lose their ref Jul 15, 2021
@Nedomas Nedomas changed the title Handle when elements they lose their ref Handle when elements they lose their ref inside TouchScrollable Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant