Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure week numbering system #141

Closed
jotaen opened this issue Jan 26, 2022 · 1 comment
Closed

Allow to configure week numbering system #141

jotaen opened this issue Jan 26, 2022 · 1 comment
Labels
ENHANCEMENT Ideas and feature requests

Comments

@jotaen
Copy link
Owner

jotaen commented Jan 26, 2022

When doing klog report --aggregate week or klog total --last-week, it follows the ISO8601 definition of the week start:

  • The first day of the week is Monday
  • The first week of the year is the week that contains the first Thursday of the year

There are different practices than ISO, however:

  • The first day of the week can also be Sunday (American)
  • The week number always starts at 1st January, even is that would be only half a week then.

Without the ability to persist configuration, the easiest is probably to let users set an environment variable, like KLOG_WEEK_NUMBERING, with values like ISO8601 (default), american (?) etc.

@jotaen jotaen added the ENHANCEMENT Ideas and feature requests label Jan 26, 2022
@jotaen jotaen changed the title Allow to configure when the week starts (Monday/Sunday) Allow to configure week numbering system Jan 30, 2022
@jotaen
Copy link
Owner Author

jotaen commented Apr 13, 2022

Transferring this to discussions. I’m not sure this is ever needed in practice, actually.

Repository owner locked and limited conversation to collaborators Apr 13, 2022
@jotaen jotaen converted this issue into discussion #182 Apr 13, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
ENHANCEMENT Ideas and feature requests
Projects
None yet
Development

No branches or pull requests

1 participant